Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General pipeline optimization #124

Merged
merged 3 commits into from
Sep 3, 2021
Merged

General pipeline optimization #124

merged 3 commits into from
Sep 3, 2021

Conversation

Tyler-Keith-Thompson
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson commented Sep 3, 2021 •
edited
Loading

@Tyler-Keith-Thompson @morganzellers
[pipeline-tweaks] - parallelized the pipeline a bit more - TT MZ
c35b2d0 
Co-authored-by: Morgan Zellers <Morgan.Zellers@gmail.com>
@Tyler-Keith-Thompson Tyler-Keith-Thompson requested a review from a team as a code owner September 3, 2021 14:26
morganzellers
morganzellers previously approved these changes Sep 3, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021 •
edited
Loading

Codecov Report

Merging #124 (ccdce50) into main (e5150d4) will decrease coverage by 2.67%.
The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   94.31%   91.64%   -2.68%     
==========================================
  Files          77       79       +2     
  Lines        1883     2071     +188     
==========================================
+ Hits         1776     1898     +122     
- Misses        107      173      +66
Impacted Files Coverage Δ
...tUIExample/SwiftUIExample/TestViews/TestView.swift 54.13% <54.13%> (ø)
...le/SwiftUIExample/TestViews/TestEnumerations.swift 86.84% <86.84%> (ø)
...ftUIExample/SwiftUIExample/SwiftUIExampleApp.swift 100.00% <100.00%> (ø)
...iftUI/Extensions/SwiftUILaunchStyleAdditions.swift 100.00% <100.00%> (ø)
...rces/SwiftCurrent_SwiftUI/Views/WorkflowItem.swift 94.77% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4b0dc...ccdce50. Read the comment docs.

@Tyler-Keith-Thompson @morganzellers
[pipeline-tweaks] - Added some options to speed up pod lib linting - …
907d02d 
…TT MZ

Co-authored-by: Morgan Zellers <Morgan.Zellers@gmail.com>
@Tyler-Keith-Thompson @morganzellers
[pipeline-tweaks] - Quick was too quick....we do not trust it - TT MZ
ccdce50 
Co-authored-by: Morgan Zellers <Morgan.Zellers@gmail.com>
Richard-Gist
Richard-Gist approved these changes Sep 3, 2021
View reviewed changes
Copy link
Collaborator

@Richard-Gist Richard-Gist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Richard-Gist Richard-Gist merged commit f5a5f6b into main Sep 3, 2021
@Richard-Gist Richard-Gist deleted the pipeline-tweaks branch September 3, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Richard-Gist Richard-Gist Richard-Gist approved these changes

@morganzellers morganzellers morganzellers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tyler-Keith-Thompson @codecov-commenter @morganzellers @Richard-Gist